This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Update CodeMirror #11652
Merged
Update CodeMirror #11652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome, thanks @marcelgerber. @nethip or anyone else, can we do a sanity check and merge this if it all looks good? |
|
@marcelgerber Thanks Marcel! Just a quick question. Have our tests passed with this change? If yes, then we should be good to go. |
|
Too bad I missed the "I've successfully run all unit and integration tests.". This looks fine to me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've successfully run all unit and integration tests.
CodeMirror releases page
Commit log
Notable changes
async/awaitin JS