fix hardcoded port in MultiBrowser LiveDevelopment and minor fix in PerfUtil #11957
Conversation
|
Travis says: |
This cause LiveDev fail if port is already taken. Now it can be changed via configuration.
kolipka
changed the title
|
We have a limit on the number of Travis builds that can go through before exceeding the Github API rate limit. It seems that dev activity was high during the time, and the rate limit exceeded. We usually retrigger the build after some time. So no worries in the case. |
| @@ -58,7 +58,7 @@ | |||
| var _clients = {}; | |||
|
|
|||
| // This must match the port declared in NodeSocketTransport.js. | |||
| // TODO: randomize this? | |||
| // Default socket port number | |||
| var SOCKET_PORT = 8123; | |||
There was a problem hiding this comment.
Since there is a pref for the socket port, this should be read from the prefs too.
There was a problem hiding this comment.
Are you sure? This is part of NodeDomain, can I read prefs there? Anyway: starting server sends port number, this here will be overwritten.
Conflicts: src/LiveDevelopment/MultiBrowserImpl/transports/NodeSocketTransport.js
If performance data gathering is disabled, markStart will return undefined instead of id. Calls like updateMeasurement and finalizeMeasurement will fail on id.id.