-
Notifications
You must be signed in to change notification settings - Fork 7.6k
ESLint: enabled no-trailing-spaces and eol-last rules #11998
Conversation
LGTM from me |
👍 from me too |
ESLint: enabled no-trailing-spaces and eol-last rules
@ficristo @zaggino As part of PR https://github.com/adobe/brackets/pull/11693/files |
@abose You are right... I'm using the eslint plugin so I didn't saw it...
|
We can add eslint also to the preferred linters for the time being. And have #11988 just have eslint alone. That would be a good transition. |
I'm not sure to have understood: do you mean changing the config to this: |
I was thinking of something like that but now figured it doesn't work like that. |
When I written the PR to integrate ESLint I tried to use similar rules to the ones already there. |
What should we do in this case then? |
@abose @zaggino @ficristo Sorry for not speaking up sooner, but I have serious concerns about this change. Brackets itself (and CodeMirror in general) automatically generates whitespace on blank lines based on indent. This ESLint rule means we will be constantly fighting with Brackets's own output, which seems like a bad policy. I would strongly suggest we change the ESLint setting to If I'd noticed this sooner I would have also suggested reverting all the changes that remove whitespace on blank lines, so that we don't have verbose diffs where people editing the code gradually start reintroducing all that indent whitespace... but I guess it's too late for that now :-/ |
I wanted to enable the
indent
rule but it seemed to be influenced by the trailing whitespaces.So I've enabled
no-trailing-spaces
rule and, since there were only a few warnings theeol-last
rule too.Sorry for the big PR but it's only whitespaces changes and so there should not be any change in behaviour.
@abose @zaggino This PR can bitrot easily: I appreciate a fast turnaround.