Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Optimize and clean up SVG icons #12164

Merged
merged 1 commit into from
Apr 1, 2016
Merged

Optimize and clean up SVG icons #12164

merged 1 commit into from
Apr 1, 2016

Conversation

valtlai
Copy link
Contributor

@valtlai valtlai commented Jan 28, 2016

  • Remove xlink namespace when not used
  • Remove svg[version] attribute
  • Remove px from pixel units
  • Remove unused ids
  • Remove useless groups
  • Optimize path data (2 decimal places)
  • Remove ry when same as rx (ry defaults to rx)
  • For consistency: lowercase hex colors, attributes order, indentation to 4 spaces

@petetnt
Copy link
Collaborator

petetnt commented Jan 28, 2016

NEAT! No visible changes according to riff diff, LGTM :shipit:

@ficristo
Copy link
Collaborator

@valtlait Did you use some tools or have you done it manually?

@valtlai
Copy link
Contributor Author

valtlai commented Jan 29, 2016

@ficristo It’s done manually, expect path optimization which is done using some regexes.

@ficristo
Copy link
Collaborator

@valtlait Thank you for the answer.

@valtlai valtlai changed the title Optimize and clean SVG icons Optimize and clean up SVG icons Jan 30, 2016
@abose abose added this to the Release 1.7 milestone Mar 31, 2016
@abose
Copy link
Contributor

abose commented Mar 31, 2016

Thanks @valtlait .
Have to verify this in hidpi displays before merging. Will merge tomorrow after checking out.

@abose abose merged commit 7f87bb4 into adobe:master Apr 1, 2016
@abose
Copy link
Contributor

abose commented Apr 1, 2016

Verified on HiDpi displays. LGTM
Merging.
Thanks @valtlait

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants