Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Refactoring QuickOpenHTML, CSS, and JavaScript extensions #12214

Merged
merged 2 commits into from
May 21, 2016

Conversation

jacobsone
Copy link

Removing shared code from QuickOpenHTML, QuickOpenCSS, and QuickOpenJavaScript and moving code into a shared file.

EditorManager.getCurrentFullEditor().setSelection(from, to, true);
}

function itemSelect(selectedItem, query) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs JSDoc

@petetnt
Copy link
Collaborator

petetnt commented Feb 16, 2016

Made few comments otherwise LGTM 👍

@abose
Copy link
Contributor

abose commented Feb 17, 2016

@jacobsone Thank you for contributing to Brackets. You will need to Accept the Brackets CLA before we can merge this pull request.
For discussions with the brackets community, please join the brackets slack channel by sending a mail to admin@brackets.io with the subject line slack registration request specifying the email addresses you would like to register.
brackets dev google groups link here .

@marcelgerber
Copy link
Contributor

LGTM too. Thank you!
Merging.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants