This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Dialog returns focus to previous element after closing #12824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting a dialog and set current focus to the previous one when closing
petetnt
suggested changes
Oct 12, 2016
| @@ -325,6 +328,10 @@ define(function (require, exports, module) { | |||
| // Remove our global keydown handler. | |||
| KeyBindingManager.removeGlobalKeydownHook(keydownHook); | |||
|
|
|||
|
|
|||
| // Restore previous focus | |||
There was a problem hiding this comment.
Nit: Remove extra newline
| @@ -325,6 +328,10 @@ define(function (require, exports, module) { | |||
| // Remove our global keydown handler. | |||
| KeyBindingManager.removeGlobalKeydownHook(keydownHook); | |||
|
|
|||
|
|
|||
| // Restore previous focus | |||
| lastFocus.focus(); | |||
There was a problem hiding this comment.
document.activeElement could be null instead of something else some rare cases, so it might be good to wrap this inside a null check
if (lastFocus) {
lastFocus.focus();
}
|
Thanks for this awesome contribution @Jerhamre! Tested and it works great. I left couple of tiny review comments, if you could fix those this is ready to be merged in 👍 |
|
Added a null check for when restoring focus and removed the extra newline |
petetnt
approved these changes
Oct 16, 2016
|
Thanks for this contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #7511, #4954, #8535.
When creating a new dialog, save the currently focused element.
When closing the dialog, restore focus to previous element.