Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Fix for 6904 #12828

Closed
wants to merge 1 commit into from
Closed

Fix for 6904 #12828

wants to merge 1 commit into from

Conversation

JoakimKLarsson
Copy link

Disabling the primary key ei "enter", when a user is typing in the search field. Enable it once a user tabs out of the search field or clicks outside it.

@ficristo
Copy link
Collaborator

#7337 does a similar thing and has a test, but there was a discussion that was the wrong approach.
Have you saw that?

@ficristo
Copy link
Collaborator

Just noticed you need to sing the CLA.
http://dev.brackets.io/brackets-contributor-license-agreement.html

@petetnt
Copy link
Collaborator

petetnt commented Oct 12, 2016

@JoakimKLarsson thanks for contributing!

I think instead of removing/adding classes like in #7337 one could just remove the focus / add the focus to the button, right? I gave this a quick test and just canceling the enter press is not enough.

@petetnt
Copy link
Collaborator

petetnt commented Oct 18, 2016

Superseded by #12839. However we do appreciate your contributions @JoakimKLarsson a lot and hope to see you send more PR's to address other issues 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants