Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Fix #11416: Enter key behaviour on Extension Manager Search Box #12839

Merged
merged 2 commits into from
Oct 18, 2016
Merged

Fix #11416: Enter key behaviour on Extension Manager Search Box #12839

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26d1c32
Fix Enter key behaviour on Extension Manager Search Box
sahildua2305 Oct 18, 2016
acc2c39
Fix ESLint error on inequality sign
sahildua2305 Oct 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/widgets/Dialogs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,9 @@ define(function (require, exports, module) {
stopEvent();
if (e.target.tagName === "BUTTON") {
this.find(e.target).click();
} else {
} else if (e.target.tagName != "INPUT") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by ESLint rules in place for project, !== is required instead of !=

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

// If the target element is not BUTTON or INPUT, click the primary button
// We're making an exception for INPUT element because of this issue: GH-11416
$primaryBtn.click();
}
} else if (e.which === KeyEvent.DOM_VK_SPACE) {
Expand Down