Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Upgrade less from 2.5.1 to 2.7.2 #13019

Merged
merged 1 commit into from
Jan 9, 2017
Merged

Upgrade less from 2.5.1 to 2.7.2 #13019

merged 1 commit into from
Jan 9, 2017

Conversation

ficristo
Copy link
Collaborator

@ficristo ficristo commented Jan 2, 2017

I would like to upgrade grunt related dependencies and this was in the way: updating only the grunt dep without the thirdparty didn't seem good.
I renamed less-2.5.1.min.js to simply less.min.js, you can see the version in the comments inside the file.

@zaggino
Copy link
Contributor

zaggino commented Jan 2, 2017

could we maybe switch to npm dependency instead?

@ficristo
Copy link
Collaborator Author

ficristo commented Jan 2, 2017

I'm all for moving to npm.
But has pointed out before by @busykai, we need to do something about the increase size of the bundle.
For example less 2.7.1 from npm is about 3MB, but the minified file is only 140kB.
I have some random thought but still nothing good.
So WDYT?

@zaggino
Copy link
Contributor

zaggino commented Jan 2, 2017

Is it about npm not providing minified file or about npm providing too many files that we don't need?

@ficristo
Copy link
Collaborator Author

ficristo commented Jan 3, 2017

Too many files, I've opened #13020 as a possible solution

Verified

This commit was signed with the committer’s verified signature.
aduh95 Antoine du Hamel
@ficristo
Copy link
Collaborator Author

ficristo commented Jan 8, 2017

Now it is fetched from npm.

@ficristo ficristo changed the title Upgrade less from 2.5.1 to 2.7.1 Upgrade less from 2.5.1 to 2.7.2 Jan 8, 2017
@zaggino zaggino merged commit 034215c into adobe:master Jan 9, 2017
@zaggino
Copy link
Contributor

zaggino commented Jan 9, 2017

👍 cool

@ficristo ficristo deleted the less branch January 9, 2017 18:55
@ficristo
Copy link
Collaborator Author

ficristo commented Jan 9, 2017

Thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants