This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Added Reverse Inspect feature in MultiBrowserLive Preview using the existing Websocket transport architecture #13103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
saurabh95
commented
Feb 14, 2017
•
saurabh95
commented
- Will add tests for reverse inspect in both Live Preview and Multibrowser Live Preview
…xisting Websocket transport architecture
petetnt
approved these changes
Feb 21, 2017
saurabh95
commented
Feb 21, 2017
| @@ -337,7 +337,7 @@ function RemoteFunctions(experimental, remoteWSPort) { | |||
| _trigger(element, "highlight", 1); | |||
| } | |||
|
|
|||
| if (!window.event && !isInViewport(element)) { | |||
| if ((!window.event || window.event instanceof MessageEvent) && !isInViewport(element)) { | |||
There was a problem hiding this comment.
check for window.event instanceof MessageEvent is added because in latest version of chrome, when it receives a message through websocket, then it considers it as window event and thus window.event is true, so we are bypassing such scenario by checking if the event is of type Message, then we can safely ignore this.
swmitra
approved these changes
Feb 22, 2017
|
@saurabh95 Please create a task to update and add tests for this feature post 1.9 release. Great work 👍 |
|
Merging... |
This was referenced Aug 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.