Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Update Finnish strings.js for (current) 1.9 #13143

Merged
merged 2 commits into from
Mar 3, 2017
Merged

Update Finnish strings.js for (current) 1.9 #13143

merged 2 commits into from
Mar 3, 2017

Conversation

39bit
Copy link
Contributor

@39bit 39bit commented Mar 2, 2017

No description provided.

@39bit 39bit changed the title Update Finnish strings.js for v1.9 Update Finnish strings.js for (current) 1.9 Mar 2, 2017
@zaggino
Copy link
Contributor

zaggino commented Mar 2, 2017

@valtlai @petetnt wanna have a look here?

petetnt
petetnt reviewed Mar 2, 2017
View reviewed changes
Copy link
Collaborator

@petetnt petetnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a comment

src/nls/fi/strings.js Outdated
@@ -154,6 +154,7 @@ define({
"FIND_QUERY_PLACEHOLDER" : "Etsi\u2026",
"REPLACE_PLACEHOLDER" : "Korvaa merkkijonolla\u2026",
"BUTTON_REPLACE_ALL" : "Kaikki\u2026",
"BUTTON_REPLACE_BATCH" : "Sarja\u2026",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this. Maybe something like "Korjaa erissä" or something, "Erä" sounds kinda weird, "sarja" too.

valtlai
valtlai reviewed Mar 2, 2017
View reviewed changes
Copy link
Contributor

@valtlai valtlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments, but looks good otherwise.

src/nls/fi/strings.js Outdated
@@ -418,6 +419,7 @@ define({
"CMD_SHOW_IN_EXPLORER" : "Näytä Resurssienhallinnassa",
"CMD_SHOW_IN_FINDER" : "Näytä Finderissä",
"CMD_SHOW_IN_OS" : "Näytä käyttöjärjestelmässä",
"CMD_SWITCH_PANE_FOCUS" : "Vaihda aktiivinen paneeli",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Vaihda ruudun valinta would be better. (Pane has been translated to ruutu elsewhere.)

src/nls/fi/strings.js Outdated
@@ -501,6 +503,7 @@ define({
"INSTALL_CANCELED" : "Asennus on peruutettu.",
"VIEW_COMPLETE_DESCRIPTION" : "Näytä täysi kuvaus",
"VIEW_TRUNCATED_DESCRIPTION" : "Näytä katkaistu kuvaus",
"SORT_EXTENSION_METHOD" : "Lajittele laajennukset käyttäen latausmäärää tai päivityspäivämäärää",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Lajittele laajennukset latausmäärän tai päivitysajankohdan mukaan.

src/nls/fi/strings.js Outdated
@@ -511,6 +514,7 @@ define({
"INVALID_VERSION_NUMBER" : "Paketin versionumero ({0}) on virheellinen.",
"INVALID_BRACKETS_VERSION" : "{APP_NAME}in yhteensopivuuden merkkijono ({0}) on virheellinen.",
"DISALLOWED_WORDS" : "Sanat ({1}) eivät ole sallittuja kentässä {0}.",
"NPM_INSTALL_FAILED" : "npm install -komento epäonnistui: {0}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to replace a dash with \u2011 (non-breaking hyphen) to prevent line break after it.

src/nls/fi/strings.js Outdated
@@ -577,6 +581,9 @@ define({
"EXTENSIONS_AVAILABLE_TITLE" : "Saatavilla",
"EXTENSIONS_THEMES_TITLE" : "Teemat",
"EXTENSIONS_UPDATES_TITLE" : "Päivitykset",
"EXTENSIONS_SORT_BY" : "Lajittele",
"EXTENSIONS_LAST_UPDATED" : "Päivitetty",
"EXTENSIONS_DOWNLOADS" : "Latausmäärä",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Latauksia.

@petetnt
Copy link
Collaborator

petetnt commented Mar 3, 2017

Hi @39bit,

could you sign the CLA so we can merge this in? http://dev.brackets.io/brackets-contributor-license-agreement.html

@39bit
Copy link
Contributor Author

39bit commented Mar 3, 2017

I have signed the CLA now. @petetnt

@zaggino zaggino merged commit e7c419a into adobe:master Mar 3, 2017
@zaggino
Copy link
Contributor

zaggino commented Mar 3, 2017 

Zaggi@ZAGGI-PC MINGW64 /d/dev/brackets-64/brackets (master)
$ grunt cla-check --user=39bit
Running "cla-check" task
39bit has submitted the contributor license agreement

@zaggino zaggino mentioned this pull request Mar 3, 2017
Merged
This was referenced Aug 30, 2021
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@valtlai valtlai valtlai left review comments

@petetnt petetnt petetnt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@39bit @zaggino @petetnt @valtlai @CosmoConsole