Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Fixes translation error in Simplified Chinese #13463

Merged
merged 1 commit into from
Jun 21, 2017

Conversation

mjaseem
Copy link

@mjaseem mjaseem commented Jun 18, 2017

@mjaseem
Copy link
Author

mjaseem commented Jun 18, 2017

Didn't expect build to fail for a change in translation. Why does it happen?
This is my first PR to any project, btw.

@ficristo
Copy link
Collaborator

If you click on the red x it redirects you to the continuos integration site we are using with the result of your PR. There are more info there.
In your case it first failed because of the api rate limit of GitHub (I think Brackets is using a free GitHub account which has a low rate limit), and now because of the CLA.

mjaseem has NOT submitted the contributor license agreement. See http://dev.brackets.io/brackets-contributor-license-agreement.html.

Also do you know someone who could review this ?

@mjaseem
Copy link
Author

mjaseem commented Jun 19, 2017

I assume the reviewer needs to be someone who's part of the project and understand Chinese. I don't know anyone like that.

I have now signed the CLA with my new username.

@ficristo
Copy link
Collaborator

You just need someone who knows Chinese.
Then someone of the Brackets team can merge.

@mjaseem
Copy link
Author

mjaseem commented Jun 20, 2017

@jiajun0308 @Xiaoyu2016 Could you review this?

@ficristo
Copy link
Collaborator

Also @FallingHeart, could you review this ?

@FallingHeart
Copy link
Contributor

of course @ficristo
the translation error has been fixed
but what am i supposed to do
or just say yes here

@ficristo
Copy link
Collaborator

Saying the translation is correct is enough.
For a more involved translation you could go to the "Files changed" tab and start a review / add comments.

@mjaseem @FallingHeart thank you!

@ficristo ficristo merged commit 29cb293 into adobe:master Jun 21, 2017
@mjaseem mjaseem deleted the jaseemumar-patch-1 branch June 22, 2017 03:25
@ficristo ficristo added this to the Release 1.10 milestone Jun 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants