Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Upgraded CodeMirror version to 5.28.0 #13596

Merged
merged 2 commits into from
Aug 8, 2017
Merged

Upgraded CodeMirror version to 5.28.0 #13596

merged 2 commits into from
Aug 8, 2017

Conversation

saurabh95
Copy link
Contributor

No description provided.

@ficristo
Copy link
Collaborator

ficristo commented Aug 5, 2017

You should also change npm-shrinkwrap.json in the src folder.
Have you run the test suite with this PR?

@saurabh95
Copy link
Contributor Author

Yeah, I have run the test suite on the upgrade.

ficristo
ficristo approved these changes Aug 5, 2017
View reviewed changes
Copy link
Collaborator

@ficristo ficristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it doesn't introduce any failure, merge it! 😄

@petetnt
Copy link
Collaborator

petetnt commented Aug 7, 2017

Fixes #13590

@swmitra swmitra merged commit baf964e into master Aug 8, 2017
@swmitra swmitra mentioned this pull request Aug 8, 2017
Closed
@ficristo ficristo deleted the saurabh95/codemirror-upgrade branch August 8, 2017 16:50
@swmitra swmitra added this to the Release 1.11 milestone Sep 22, 2017
@core-ai-bot core-ai-bot mentioned this pull request Aug 30, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ficristo ficristo ficristo approved these changes

@petetnt petetnt petetnt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 1.11
Development

Successfully merging this pull request may close these issues.
4 participants
@saurabh95 @ficristo @petetnt @swmitra