This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fixes wrong function call in ProjectManager.js #13611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The createNewItem function in ProjectManager.js calls the createAtPath in Projectmodel.js. The function call expects a single parameter, which is the path at which the file must be created. And it expects a "/" in the end of the path in case it is a folder. However, right now 2 parameters are being passed. One of them being the isFolder variable.
saurabh95
approved these changes
Aug 12, 2017
|
Thanks for the contribution! |
|
Signed it! |
swmitra
approved these changes
Aug 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The createNewItem function in ProjectManager.js calls the createAtPath in Projectmodel.js.
The function call expects a single parameter, which is the path at which the file must be created.
And it expects a "/" in the end of the path in case it is a folder.
However, right now 2 parameters are being passed. One of them being the isFolder variable.