-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Bringing in ImmutableJS 3.8.2 #14168
Bringing in ImmutableJS 3.8.2 #14168
Conversation
Thanks for the PR @vickramdhawal 👍 Did you get a chance to run unit tests? |
Also looks like CLA has not been signed that is why the travis tests are failing. Can you signup using this link? Please sign the CLA here http://dev.brackets.io/brackets-contributor-license-agreement.html. |
I've signed up now. I did run all tests, but have to bear with multiple dialogs to get it to completion. Will update once its done. |
Thanks @vickramdhawal I have restarted the build. |
You can disable the dialog popups by returning from the below function. We will have to figure out other means of handling the dialog popups. |
immutableJS is used only by the FileTreeView & the FileTreeViewModel and the tests are passing for both. Unit tests are also passing except for the ones already failing on master. |
Good work @vickramdhawal. |
@@ -12,6 +12,8 @@ package-lock.json | |||
|
|||
# ignore node_modules inside src | |||
/src/node_modules | |||
/src/JSUtils/node_modules | |||
/src/JSUtils/node/node_modules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this fixes the effects and not the cause of the problem.
Bringing in ImmutableJS 3.8.2 which is release under MIT license. Source of immutableJS https://github.com/facebook/immutable-js/releases/tag/v3.8.2.
Also updating the gitignore file to exclude node_modules inside src/JSUtils