This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix for CodeHint Description CSS Issue #14728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To calculate the offset for the code hint description I was using a dummy div earlier. This was causing the parent element (anchor for the codehint menu) to inherit the height of the dummy div and overlap with certain area of the editor outside of the codehint list. Due to this we were not able to put cursor on the overlapped area.
Solution: Fixing this issue by using a modified approach which doesn't require a dummy div. Instead, we rely on absolute positioning and adjust the top margin on the description box according to codehint menu height.
ping @swmitra @narayani28 @niteskum for review.