Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Spanish localization #1587

Merged
merged 9 commits into from
Sep 10, 2012
Merged

Spanish localization #1587

merged 9 commits into from
Sep 10, 2012

Conversation

jbalsas
Copy link
Contributor

@jbalsas jbalsas commented Sep 7, 2012

Spanish localization. Includes strings.js and Getting Started translations.

"ERROR_CREATING_FILE" : "Ha ocurrido un error al intentar crear el archivo <span class='dialog-filename'>{0}</span>. {1}",

// Application error strings
"ERROR_IN_BROWSER_TITLE" : "Vaya... parece que {APP_NAME} todavía no funciona en navegadores.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google translate returned "Wow ... looks like {APP_NAME} still does not work in browsers". Maybe the translation is bad? But maybe this can be worded more gently saying that it Brackets doesn't work in browsers "yet". If the translation is correct, it makes us sound slow. ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get your point :) This is a Google Translate problem though. Both "yet" and "still" translate to "todavía" or "aún", but they all mean the same. It sounds ok in spanish, not slow at all ;)

If you're not satisfied, we could change it for "por ahora" which would result in "Brackets doesn't work in browsers for now"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine as is. Thanks.

@jasonsanjose
Copy link
Member

Initial review complete. Needs to merge with master.

@jasonsanjose
Copy link
Member

Just a note about your last merge. I noticed you combined the merge and the code review changes in the same commit. For future commits, it would be easier for us to review if the merge commits are purely merge reconciliation, separate from requested changes.

@jasonsanjose
Copy link
Member

Nice job. Merging.

jasonsanjose added a commit that referenced this pull request Sep 10, 2012
@jasonsanjose jasonsanjose merged commit b323be3 into adobe:master Sep 10, 2012
@nestorrojas
Copy link

I think It´d be better to use the word "Sangría" instead of "indentación". That word doesn´t exist in spanish language.

@nestorrojas
Copy link

I forgot to say that it would be nice too if translations menu commands would be as in Adobe´s software, ie "Visualización" is "Vista" in Adobe´s apps. Just a matter of coherence between Adobe apps.

@jbalsas
Copy link
Contributor Author

jbalsas commented Oct 3, 2012

@nestorrojas Hi, there are some new strings coming out so I was planning on putting together a new pull request. Maybe we could discuss your suggestions.

I didn't really realize indentación is not a real spanish word. I actually use it everyday :D. I don't really like Sangría for this. Maybe we could go for something in the line of Increment level or Shift right with a translation such as Desplazar a la izquierda or Incrementar Nivel... How do you feel about this? @jasonsanjose Would this be a suitable equivalent for Indent?

About consistence between the rest of Adobe's software, I don't think it is really required, because maybe context is different, but it could be nice. I don't have any apps in spanish right now, so could you compile here those translations, please?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants