This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
fixed #1508 : Root folders show nothing in recent projects list after the "-" (no path or drive name) #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…after the "-" (no path or drive name) Signed-off-by: Rifat Nabi <to.rifat@gmail.com>
* 'master' of git://github.com/adobe/brackets: (22 commits)
Use achored regexp
Fix unit tests when run from symlinked directory
Remove the local assignment to endQuote and directly use the quote character.
Fix alt text for French version of Getting Started
missing translation in CMD_LINE_DOWN
Misc. improvements
Automatically wrap the selected attribute value with double quotes if the begin quote is missing. Also update some unit tests for this functionality change.
Merge branch 'master', remote-tracking branch 'origin' into rlim/code-hint-issues
fix case in nls/strings.js module.exports object
Replace "Brackets" with "{APP_NAME}", sync with nls/root/strings.js
Typo: "forige" -> "forrige"
Better usage messages. Check for XP.
added no_content_bg.svg and modified the styles to display it.
Windows scripts for setting up/restoring dev environment.
Change about h2 margin-bottom to -4px
Add tools directory.
tweak about h2 spacing
remove unused string
working set files are not guaranteed to be openable, so check for failure
Sync with root/strings.js
...
ghost
assigned 
|
Your changes fix the issue that I mentioned in #1508, but there is a related issue that @njx mentioned in the comment and that issue is not fixed yet. The related issue can be reproduced if you select the entire mac drive as your project folder. In that case, nj wants to show the project name as "/". |
|
@RaymondLim Ok, I'll send a revised pull request 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't own a windows so didn't able to check it in windows. Also there are no tests available for this module.