-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Conversation
In review |
@@ -0,0 +1,139 @@ | |||
<!DOCTYPE html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is still in english. Did you intend to translate this to italian? If you don't translate it, then you should revert your change to src/nls/urls.js.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I'll try to translate tomorrow, otherwise I'll revert my change
Hi @antonellopasella. Before continuing please sign the Brackets CLA http://dev.brackets.io/brackets-contributor-license-agreement.html. |
"ABOUT" : "About", | ||
"APP_NAME" : "Brackets", | ||
"CLOSE" : "Chiudi", | ||
"ABOUT_TEXT_LINE1" : "sprint 14 experimental build ", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to sprint 15
Initial review complete |
Fixed some typos and some missing lines
Edited my master branch. It's enough? Thanks for the kind review |
Yes, and thanks for signing the CLA. Your changes look good. Thanks for the contributions! If you like, you can revert the src/nls/urls.js change and I can merge it now. Otherwise, I will wait and merge it when the getting started content is translated. I'll let you choose. Thanks. |
Reverted. I'll try to fix the italian translation of the "welcome page" tomorrow.
Reverted. I'll add a new pull request ASAP :D p.s. the "revert" is correct or there is a better way to do a real revert? Thanks! |
Revert worked. Merging now. |
No description provided.