This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Add 'Rename' and 'Show in Tree' to working set context menu #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change ProjectManager.renameSelectedItem() -> renameItemInline(entry) so the item doesn't have to be selected in the tree UI. * Fix ProjectManager._findTreeNode() (and thus showInTree()) to work for folders * showInTree() now returns its Promise for tracking
| }) | ||
| .fail(function (err) { | ||
| // Error during rename. Reset to the old name and alert the user. | ||
| _projectTree.one("rename.jstree", function (event, data) { |
There was a problem hiding this comment.
Note small cleanup here: using one() in place of on() with immediate off().
ghost
assigned 
| @@ -767,10 +767,10 @@ define(function (require, exports, module) { | |||
|
|
|||
|
|
|||
| /** | |||
| * Returns the tree node corresponding to the given file/folder. Returns null if the path lies | |||
| * Finds the tree node corresponding to the given file/folder (rejected if the path lies | |||
| * outside the project, or if it doesn't exist. | |||
|
Nice additions! Merging. |
gruehle
added a commit
that referenced
this pull request
Oct 23, 2012
Add 'Rename' and 'Show in Tree' to working set context menu
| @@ -1166,56 +1176,58 @@ define(function (require, exports, module) { | |||
| } | |||
|
|
|||
| /** | |||
| * Rename the selected item in the project tree | |||
There was a problem hiding this comment.
"Inline editor" leads me to think of "Quick Edit" type of inline editor that is located in the editor area.
This was referenced Oct 23, 2012
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: the diff in ProjectManager has a large block indentation change, so it might be helpful to view the diff with
?w=1appended to the URL.@gruehle: since you added Rename originally, I thought you might like to review?