Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Fix for dropping projects when cancelling switch (#1780) #2013

Merged
merged 2 commits into from
Nov 2, 2012
Merged

Fix for dropping projects when cancelling switch (#1780) #2013

merged 2 commits into from
Nov 2, 2012

Conversation

jbalsas
Copy link
Contributor

@jbalsas jbalsas commented Nov 1, 2012

Possible fix for #1780

As @pthiess pointed out, checking to see if the folder exists to prevent it from being dropped.

@ghost ghost assigned redmunds Nov 1, 2012
@@ -148,7 +149,11 @@ define(function (require, exports, module) {
// Remove the project from the list.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this comment to something like:

// If folder does not exist on disk then remove the project from the list

@redmunds
Copy link
Contributor

redmunds commented Nov 1, 2012

This looks good. Just a couple minor changes.

@jbalsas
Copy link
Contributor Author

jbalsas commented Nov 2, 2012

@redmunds It should be good to go now.

As a side note, passing fault codes in the reject calls could be helpful in cases like this. In this issue, there are at least 4 ways openProject can fail, and only one should require dropping the project from the list, but we need to check every time anyway.

A quick search reveals that less than half the reject calls are passing some error code, but I guess it can become a mess for some cases that end up chaining different promises though...

@redmunds
Copy link
Contributor

redmunds commented Nov 2, 2012

This is not common case, so I think this is OK. Looks good. Merging.

redmunds added a commit that referenced this pull request Nov 2, 2012
Fix for dropping projects when cancelling switch (#1780)
@redmunds redmunds merged commit 119f22e into adobe:master Nov 2, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants