Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Inform the user about missing libraries #2440

Merged
merged 15 commits into from
Jan 2, 2013
Merged

Inform the user about missing libraries #2440

merged 15 commits into from
Jan 2, 2013

Conversation

jdiehl
Copy link
Contributor

@jdiehl jdiehl commented Dec 23, 2012

This seems to be a recurring issue on the mailing list, so it might make everyone's life easier to simply inform the user about missing libraries and how to fix that inside brackets. I added a simple script at the end of bracket.html that checks whether all required libraries are loaded after a fixed time interval (1 second) and informs the user if something is missing.

Conflicts:
	src/brackets.js
	src/command/Menus.js
	src/debug/DebugCommandHandlers.js
	src/nls/strings.js
	src/strings.js
	src/thirdparty/i18n.js
@ghost ghost assigned gruehle Jan 2, 2013
document.write("<p>If you have checked up Brackets from github, please update the submodules by running the following command:</p>");
document.write("<pre>git submodule update --init</pre>");
document.write("<p><a href=\"#\" onclick=\"window.location.reload()\">Reload Brackets</a></p>");
}, 1000);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably bump this up to 2 seconds in case the user is running on a really slow (or bogged down) machine.

@gruehle
Copy link
Member

gruehle commented Jan 2, 2013

@jdiehl - thanks for submitting this. It is definitely one of the top support issues when running from source.

I have some suggestions on the wording to simplify things a bit:


Missing Libraries

Oops! One or more required libraries could not be found.

If you are running from a local copy of the Brackets source, please make sure submodules are updated by running

git submodule update --init

If you're still having problems, please contact us via one of the channels mentioned in the README

Reload Brackets

@jdiehl
Copy link
Contributor Author

jdiehl commented Jan 2, 2013

Thanks for the suggestion, changed it!

@jdiehl
Copy link
Contributor Author

jdiehl commented Jan 2, 2013

I am opening the local version of the README in a new window to avoid users being stuck in the README (there are no navigation buttons).

@gruehle gruehle merged commit 999c7d5 into adobe:master Jan 2, 2013
@gruehle
Copy link
Member

gruehle commented Jan 2, 2013

Merged with a couple minor wording tweaks in 90519fa

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants