Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

CSS Code Hinting for new CodeHintManager-API #2492

Closed
wants to merge 70 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
70 commits
Select commit Hold shift + click to select a range
ac3a731
added syntax highlighting for *.xsd and *.xsl files, which use xml-sy…
Nov 4, 2012
8606b80
added xml-syntax highlighting to xsd and xsl files
Nov 7, 2012
66ce557
Merge remote-tracking branch 'upstream/master' into csshinting
Nov 7, 2012
097b412
initial commit on CSSCodeHint
Nov 7, 2012
705d060
Added properties-file to repo
Nov 12, 2012
90cebec
Merge remote-tracking branch 'upstream/master' into andrez/csshinting
Nov 12, 2012
d562234
added some more infrastructure for testing in the style of HTMLCodeHint
Nov 12, 2012
da528f2
added needed functions for codehintprovider in csscodehints
Nov 13, 2012
951ff71
added code to determine filecontext like .cssfiles or styletags
Nov 15, 2012
eea3deb
Added more unit tests handling general css hint features.
Nov 18, 2012
40a5f6a
Implemented search for what has been typed so far.
Nov 18, 2012
186b84b
rearranged tests around mocks and added suites for handleSelects and …
Nov 18, 2012
5032257
restructured getQueryInfo for better further development
Nov 18, 2012
189680d
minor typos
Nov 18, 2012
ba820b8
added more unittests with regards to style-tags
Nov 19, 2012
d09cb15
added whitespace to set of keys to trigger hints
Nov 19, 2012
24c760b
added unittests for attributes values
Nov 20, 2012
e9e6735
first early implementation for attrvalues (no handleselect yet)
Nov 20, 2012
3cf28ed
disable handleSelect until a proper concept is developed and the rest…
Nov 20, 2012
bc63e60
added files for quicktesting without changing folders (will be remove…
Nov 20, 2012
5305648
corrected typo that caused the document not to be a correct htmldocum…
Nov 20, 2012
ca049a5
(temporarily) disabled the unittests for handleSelects
Nov 20, 2012
45146a6
added further csscontexttest to determine whether the cursor is reall…
Nov 20, 2012
7a0defc
added unittests for handleSelect and reworked a test to describe a pr…
Nov 25, 2012
184f48e
implemented handleSelect based on getQueryInfo
Nov 25, 2012
a60c0be
added unittest for handleSelects directly after a (semi-)colon
Nov 25, 2012
15e1b11
added code to fix wrong behaviour when the cursor was next to a (semi…
Nov 25, 2012
a49964c
added colon to the list of special chars for exclusion in handleSelect
Nov 25, 2012
8b829a9
tidied up code to catch all jslint errors in main.js
Nov 26, 2012
db7886f
changed csscontext-analysis to only use getModeForSelection (tipp fro…
Nov 26, 2012
7e34c6a
minor tidy-up of code in getQueryInfo
Nov 26, 2012
ed8eb8c
tidy up unit tests
Nov 26, 2012
ce73c5e
added unittest from other branch (which was wrongly added in this bra…
Nov 28, 2012
77e4b73
Merge remote-tracking branch 'upstream/master' into andrez/csshinting
Nov 28, 2012
0ecb2fb
improved getQueryInfo to better check differentiate between at-rules …
Nov 28, 2012
3827239
added some unittests to describe more scanrios for handleSelect which…
Nov 28, 2012
e9bd4fe
added a another (slightly different) test for handleSelect (2 out of …
Nov 28, 2012
93f83e6
added unittest for handleSelect with inproper input
Nov 30, 2012
7036ae7
reordered some code in getQueryInfo to resemble normal behaviour bett…
Nov 30, 2012
3862911
added minor css to testfile
Nov 30, 2012
ab89840
added code to let hintlist open if property was entered, so possible …
Nov 30, 2012
c2347c4
Implement registerHintProvider api with extra parameters suggested by…
RaymondLim Dec 4, 2012
676ca72
Putting back shouldShowHintsOnKey api since JS code hinting Ian is wo…
RaymondLim Dec 5, 2012
53c1d94
Correct some mistakes in jsDoc.
RaymondLim Dec 6, 2012
ea97d4e
Add one more code hints extension api to let the provider decide on t…
RaymondLim Dec 6, 2012
c099f5e
Use a local variable to avoid modifying the parameter.
RaymondLim Dec 6, 2012
ba32cb5
modeName sounds better.
RaymondLim Dec 6, 2012
44617d7
Merge remote-tracking branch 'upstream/rlim/new-code-hints-manager' i…
Dec 14, 2012
c527f9e
merged new CHMapi and made csscodehint working again
Dec 14, 2012
b0645a6
merged with upstream/master
Jan 5, 2013
deca1e1
changing csshinting to new CHMapi (code not stable right now)
Jan 5, 2013
4fcf4ec
further implemented hasHints, getHints, (todo: insertHints) - still n…
Jan 5, 2013
a071c33
integrated insertHints in main.js
Jan 5, 2013
a4e26e4
refactored unittests to use new methods
Jan 5, 2013
1d17ea1
removed unneccesary (old) code
Jan 5, 2013
147d0bc
added more triggerkeys and removed unused variables in hasHints/getQu…
Jan 5, 2013
47dc095
added space to triggerkeys, but excluded the initialSelection for tha…
Jan 6, 2013
00ddb54
fixing unittests, so that they validate again
Jan 8, 2013
20ffb27
fixed remaining (failed) unittests
Jan 8, 2013
3522aac
Merge remote-tracking branch 'upstream/master' into andrez/csscodehin…
Jan 8, 2013
d7381a9
changed the triggerKeys to primary and secondary, as well removed unn…
Jan 8, 2013
e7243a2
removed quicktesting from repo
Jan 8, 2013
f37b6c2
commented out the logging of the cssutils.info
Jan 8, 2013
ea8d5d0
Merge remote-tracking branch 'upstream/master' into andrez/csscodehin…
Jan 8, 2013
cad4531
reverted CHM and htmlhinting.main.js to upstream/master
Jan 8, 2013
a1ae0a4
Merge remote-tracking branch 'upstream/master' into andrez/csscodehin…
Jan 8, 2013
c7b5504
removed xsl/xml highlighting - only csscodehinting-related files changed
Jan 8, 2013
d37f9ea
reset .gitignore
Jan 8, 2013
719e739
added defaultcomments to functions
Jan 8, 2013
2c3e786
removed unsused var
Jan 8, 2013
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
modeName sounds better.
RaymondLim committed Dec 6, 2012

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit ba32cb5c85953cd1e5d5b25700147f23f27af34c
4 changes: 2 additions & 2 deletions src/editor/CodeHintManager.js
Original file line number Diff line number Diff line change
@@ -84,8 +84,8 @@ define(function (require, exports, module) {
_mergeAllModeToIndividualMode();
}

var modeStr = (typeof mode === "string") ? mode : mode.name;
return hintProviders[modeStr] || [];
var modeName = (typeof mode === "string") ? mode : mode.name;
return hintProviders[modeName] || [];
}

/**