This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fixed: Issue 3041 If you remove displayKey for Decrease Font Size shortcut, it will show up as Ctrl++ on Window #3331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you could use regular lookahead: This expression seems like a closer match to what we're trying to accomplish anyway: we don't care about doubled "--"s so much as we care about "-"s that are the last char in the string (i.e. "-"s that are the keystroke rather than the delimiter). |
|
you are right, as the "-" we care about will always be at the end of the string this should work too. |
|
@peterflynn changes pushed. |
|
Looks good. Merging. |
RaymondLim
added a commit
that referenced
this pull request
Apr 16, 2013
Fixed: Issue 3041 If you remove displayKey for Decrease Font Size shortcut, it will show up as Ctrl++ on Window
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3041 by mimiking a negative lookbehind.