This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Bash language support #3348
Merged
Bash language support #3348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks great other than the syntax highlighting bug that appears twice in your screenshot, you mean :-D (I still agree it's worth merging though) |
|
OK, you got me! See codemirror/codemirror5#1423. |
|
Looks good. Merging. Looks like your change to CodeMirror will be in our next merge (probably at the start of Sprint 24). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an entry to the languages.json file for Bash language support, by way of the CodeMirror "shell" mode. (That mode seems mainly for Bash, even though it's called "shell".) It looks great!