This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Locale descriptions in switching language modal. #3704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
@tammo Before we can merge your pull request, you need to sign up our CLA which is available at http://dev.brackets.io/brackets-contributor-license-agreement.html |
| "LOCALE_PT_PT" : "Portuguese", | ||
| "LOCALE_RU" : "Russian", | ||
| "LOCALE_SV" : "Swedish", | ||
| "LOCALE_TR" : "Turkish ", |
There was a problem hiding this comment.
Why do we have a trailing space here?
There was a problem hiding this comment.
I thought i stick to the formatting thats used across the file.
There was a problem hiding this comment.
Sorry, I was referring to the extra space after the word "Turkish".
There was a problem hiding this comment.
Ah sorry, that space should not be there ;)
|
Done with initial review. |
|
signing CLA ✓ |
|
Looks good. Merging. |
RaymondLim
added a commit
that referenced
this pull request
May 9, 2013
Locale descriptions in switching language modal.
|
Thanks @tammo. I've moved the trello card https://trello.com/c/Pjw3vGt2 to our Brackets History - Community Done list. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here i take up the pull request #3677.
I added english i18n for the locales and i moved them in the strings.js to the modal strings.
additional infos:
issue #1461
card https://trello.com/c/Pjw3vGt2
I also removed the locale label string, because a short descriptions "feels" a lot more usable than a locale in ( ). So now there will be plain "English" instead of "en". And because of the fallback there wont be a plain locale in the modal anymore.