This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Skip dropped files that are already open #4447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| // If the file is already open, and this isn't the last | ||
| // file in the list, return. If this *is* the last file, | ||
| // always open it so it gets selected. | ||
| if (idx < files.count - 1) { |
|
Reviewed, just found one bug. |
|
@njx - thanks, fix pushed. |
|
It turns out that the logic for which one gets opened last isn't bulletproof due to race conditions, since all the opens are executing in parallel. In particular, if you drag on a group of files and some file other than the last one isn't already open, that's the one that will end up as selected (rather than the last one), because the already-opened last one completes earlier. But I don't think that matters, and arguably the behavior is actually reasonable (i.e. the user probably wants to see the one that wasn't already open, though if we wanted that explicitly, we shouldn't rely on the race). Anyway, tl;dr - I'm going to merge this anyway :) |
njx
pushed a commit
that referenced
this pull request
Jul 15, 2013
Skip dropped files that are already open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #4429
If a dropped file is already open, skip it.