Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Issue #4453: Parameter "{0}" appears in the invalid filename title. #4491

Merged
merged 2 commits into from
Jul 17, 2013
Merged

Issue #4453: Parameter "{0}" appears in the invalid filename title. #4491

merged 2 commits into from
Jul 17, 2013

Conversation

TomMalbran
Copy link
Contributor

Easy fix for Issue #4453

* Check a filename for illegal characters. If any are found, show an error
* dialog and return false. If no illegal characters are found, return true.
* @param {string} filename
* @param {boolean} isFolder
* @return {boolean} True if the filename has illegal characters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo? Returns returns false if filename has illegal chars.

@ghost ghost assigned adragomir and jasonsanjose Jul 17, 2013
@jasonsanjose
Copy link
Member

Initial review complete

@TomMalbran
Copy link
Contributor Author

@jasonsanjose Woops. Fixed now.

@jasonsanjose
Copy link
Member

Thanks. Merging.

jasonsanjose added a commit that referenced this pull request Jul 17, 2013
Issue #4453: Parameter "{0}" appears in the invalid filename title.
@jasonsanjose jasonsanjose merged commit 22959e4 into adobe:master Jul 17, 2013
@TomMalbran TomMalbran deleted the tom/issue-4453 branch July 19, 2013 04:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants