This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Followup updates to #4581 and #4598 #4629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Nominating sprint 30 |
|
Moving to sprint 31 |
|
@TomMalbran can you merge with master? |
|
Yes I can... 1 min |
|
@jasonsanjose Done |
| */ | ||
| function cancelModalDialogIfOpen(dlgClass) { | ||
| function cancelModalDialogIfOpen(dlgClass, buttonId) { | ||
| $("." + dlgClass + ".instance").each(function () { | ||
| if ($(this).is(":visible")) { // Bootstrap breaks if try to hide dialog that's already hidden | ||
| _dismissDialog($(this), DIALOG_CANCELED); |
There was a problem hiding this comment.
Looks like a bad merge. This was buttonId || DIALOG_CANCELED.
There was a problem hiding this comment.
Oh, yeah... good catch!
|
@TomMalbran just 2 minor comments. |
|
@jasonsanjose Fixed. |
|
Looks good and tests are passing. Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cancelModalDialogIfOpen.@jasonsanjose Want to review this? No rush thought, since the changes are just minor updates.