Quick Edit tweak #5230
Quick Edit tweak #5230
Conversation
| listItem.attr("title", text); | ||
| var text = range.name + " <span class='related-file'>— " + range.textRange.document.file.name + " : " + (range.textRange.startLine + 1) + "</span>"; | ||
| listItem.html(text); | ||
| listItem.attr("title", range.name + " " + range.textRange.document.file.name + " : " + (range.textRange.startLine + 1)); |
There was a problem hiding this comment.
You might be able to replace this with listItem.attr(listItem.text())... could you try it out locally and see if that gives the right tooltip?
There was a problem hiding this comment.
Thanks Peter, it's so much better!
|
@larz0 Looks good other than those two comments! |
ghost
assigned 
|
Assigned to @njx |
|
@larz0 Looks great - just my one additional comment. |
|
@larz0 here's the comment I made - it's hidden right now because it was on one of the outdated diffs: I think we might need to escape |
|
@njx fixed. |
|
Looks good. It turns out this broke one of the unit tests due to the string change, so I pushed up a fix for that as well. Merging. |
This is for http://forums.adobe.com/message/5678318#5678318