Update CodeMirror for sprint 32. Avoid hang by setting width on mock editor holder in unit tests. #5283
Conversation
…editor holder in unit tests.
ghost
assigned 
| @@ -406,7 +406,7 @@ define(function (require, exports, module) { | |||
| function createMockEditorForDocument(doc, visibleRange) { | |||
| // Initialize EditorManager/PanelManager and position the editor-holder offscreen | |||
| // (".content" may not exist, but that's ok for headless tests where editor height doesn't matter) | |||
| var $editorHolder = createMockElement().attr("id", "mock-editor-holder"); | |||
| var $editorHolder = createMockElement().css("width", "1000px").attr("id", "mock-editor-holder"); | |||
There was a problem hiding this comment.
This change indeed fixes the hang issue.
|
I updated to the latest upstream, re-ran the unit tests and did a little smoke testing. When running all the unit tests I ran into one failure in MultiRangeInlineEditor-test, but it didn't repro when clicking on it by itself. Looking at the test, it seems like there's potentially some async issues with the tests themselves (they don't wait for async opening/closes to finish, and the animations for the inline editors actually don't exist in the test runner window, similar to other bugs we've had). So I don't think that's related to the latest update. I'll file a separate bug on these I"m going to go ahead and merge this since it seems okay. |
Update CodeMirror for sprint 32. Avoid hang by setting width on mock editor holder in unit tests.
|
@RaymondLim - can you double-check again that the original bug is still fixed? (I just realized I didn't retest it after pulling the new CM.) If so, please close it. |
@RaymondLim
See comments in #5179. I verified that all the automated tests pass and smoke tests are ok after this change.
Could you also verify that the issues caused by codemirror/codemirror5#1787 are also fixed after this update, and close that bug as well as our own related issues? Thanks.