This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Stop inline-header filename from resizing. #5680
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned …no-inline-header-resize
|
The file name size is fixed, but it looks like the header height still adjusts with the text size, to the close button doesn't stay aligned with the file name. This screen shot is after hitting Ctrl-+ 30 times and then turning on Dev Tools > Elements panel. Maybe try adjusting the baseline on the close button? |
|
@redmunds should be fixed now. |
| @@ -665,6 +665,11 @@ a, img { | |||
| } | |||
|
|
|||
| /* Styles for inline editors */ | |||
|
|
|||
| .inline-text-editor { | |||
| line-height: 0px !important; | |||
There was a problem hiding this comment.
Yes, that fixes it.
I don't !important is needed here. I removed it and it still seems to work. Can we remove it?
|
@redmunds !important removed~ |
|
Squashed these commits and merged in #5818. Closing. |
This was referenced Aug 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #5641.