Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Fix for #5923: Maintain scroll position for each ExtensionManager tab #6637

Merged
merged 2 commits into from
Jan 26, 2014
Merged

Fix for #5923: Maintain scroll position for each ExtensionManager tab #6637

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6032ff8
Maintain scroll position for each ExtensionManager tab
Jan 24, 2014
4942d91
Removing newlines
Jan 26, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/extensibility/ExtensionManagerDialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,9 @@ define(function (require, exports, module) {
// Dialog tabs
$dlg.find(".nav-tabs a")
.on("click", function (event) {
models[_activeTabIndex].scrollPos = $(".modal-body", $dlg).scrollTop();
$(this).tab("show");
$(".modal-body", $dlg).scrollTop(models[_activeTabIndex].scrollPos || 0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit. Probably don't need the newline characters, just keeping with the existing coding style. Otherwise, it looks good. Nice, simple change.

Probably don't need unit tests. Small, localized change. If it fails, nothing will break.

});

// Update & hide/show the notification overlay on a tab's icon, based on its model's notifyCount
Expand Down