locale_id #6812

pace-noge · 2014-02-09T03:17:31Z

Add indonesian language

marcelgerber · 2014-02-12T17:31:08Z

src/nls/id/strings.js

+    "BAD_PACKAGE_NAME"                     : "{0} Paket tidak valid.",
+    "MISSING_PACKAGE_VERSION"              : "package.json tidak menyebutkan versi paket.",
+    "INVALID_VERSION_NUMBER"               : "Versi ({0}) tidak valid.",
+    "INVALID_BRACKETS_VERSION"             : "T{APP_NAME} compatibility string ({0}) is invalid.",


I don't know the indonesian language, but is this intended? Shouldn't there be a space after T?
This will print out like TBrackets compatibility string ([...]) is invalid.

@pace-noge We don't know the indonesian language, but we think that the uppercase 'T' for ´INVALID_BRACKETS_VERSION´'s value might be there misplaced there. Could you please check and update? Thank you!

Sorry for the typo i'll update it now.. Thank you.
On Feb 13, 2014 6:41 AM, "Ingo Richter" notifications@github.com wrote:

In src/nls/id/strings.js:

"INSTALL_EXTENSION_LABEL" : "URL Ekstensi",

"INSTALL_EXTENSION_HINT" : "URL file zip extensi atau GitHub repo",

"INSTALLING_FROM" : "Menginstal Ekstensi dari {0}\u2026",

"INSTALL_SUCCEEDED" : "Sukses!",

"INSTALL_FAILED" : "Gagal.",

"CANCELING_INSTALL" : "Membatalkan\u2026",

"CANCELING_HUNG" : "Pembatalan memakan waktu terlalu lama. Terjadi kesalahan internal.",

"INSTALL_CANCELED" : "Instalasi Dibatalkan.",

// These must match the error codes in ExtensionsDomain.Errors.* :

"INVALID_ZIP_FILE" : "Bukan berkas zip yang valid.",

"INVALID_PACKAGE_JSON" : "Berkas package.json tidak valid (error was: {0}).",

"MISSING_PACKAGE_NAME" : "Berkas package.json tidak menyebutkan nama paket.",

"BAD_PACKAGE_NAME" : "{0} Paket tidak valid.",

"MISSING_PACKAGE_VERSION" : "package.json tidak menyebutkan versi paket.",

"INVALID_VERSION_NUMBER" : "Versi ({0}) tidak valid.",

"INVALID_BRACKETS_VERSION" : "T{APP_NAME} compatibility string ({0}) is invalid.",

@pace-noge https://github.com/pace-noge We don't know the indonesian
language, but we think that the uppercase 'T' for
´INVALID_BRACKETS_VERSION´'s value might be there misplaced there. Could
you please check and update? Thank you!

Reply to this email directly or view it on GitHubhttps://github.com//pull/6812/files#r9691741
.

resir014 · 2014-03-04T06:58:51Z

@ingorichter: Exactly as @pace-noge said. In Indonesian we have no plural forms when specifying a number of things. When specifying more than one line, or "baris" as you say it in Indonesian, we simply use "2 baris".

I can also help fixing some spelling issues perhaps.

ingorichter · 2014-03-04T18:33:03Z

@resir014 @pace-noge Thank you for clarifying this for me. I don't know Indonesian and all the questions I've asked and corrections I've proposed were basically a result of my review using google translate.

ingorichter · 2014-03-04T18:50:11Z

src/nls/id/strings.js

+    "CMD_QUICK_OPEN"                      : "Buka Cepat",
+    "CMD_GOTO_LINE"                       : "Ke Baris",
+    "CMD_GOTO_DEFINITION"                 : "Cari Cepat Penjelasan",
+    "CMD_GOTO_FIRST_PROBLEM"              : "Ke Kesalhan/Peringatan Pertama",


Should this be Kesalahan instead of Kesalhan?

pace-noge · 2014-03-04T20:03:11Z

@ingorichter sorry for so many typo, thank you for clarifying. I suggest to use sederet.com instead google translate to translating. Some time google translate not too accurate translation

ingorichter · 2014-03-04T22:11:24Z

@pace-noge That's why we look very close at the translation in the beginning to catch typos and formatting issues.Thanks for the translation. I'm done with my initial review. Thank you for the tip with sederet.com. If you have a chance to resolve all the mentioned issues, I can merge it to master and it will appear in our upcoming release next week. :-)

resir014 · 2014-03-05T00:56:45Z

@ingorichter Just a few heads-up, I'm still finding some typos within the strings, although I'm new to git and it might take me a while to get into it.

ingorichter · 2014-03-05T01:15:03Z

@resir014 I don't think that I found all the typos. I don't speak the language and I asked only at strings where google translate proposed something different. ;-)

resir014 · 2014-03-05T01:29:28Z

On line 427, "mwnginstall" should be "menginstal", with a single l. :)

ingorichter · 2014-03-05T07:06:21Z

@resir014 I don't think that I found all the typos. I don't speak the language and I asked only at strings where google translate proposed something different. ;-)

pace-noge · 2014-03-05T07:45:27Z

@resir014 tombol editnya di enable ga?, klo di enable lgsg edit aja.. atau kalo ngga di fork dulu yang branch id di repo saya.. trus di edit nnti dimerge sama yang branch saya baru di merge lagi ke bracketnya kalo udh bener semua.. terima kasih sudah membantu. :)

resir014 · 2014-03-05T07:47:25Z

@pace-noge OK, sama-sama, nanti saya coba :)

@resir014

fixed typo and using link from @resir014 for reference

resir014 · 2014-03-06T16:00:46Z

@ingorichter @pace-noge Oh, also, before I forgot about this, should I add a translation to the Getting Started page as well?

ingorichter · 2014-03-06T17:55:37Z

@resir014 That would be great! It's doesn't have to be in this PR. You can create a new PR for this and I can go ahead an merge this PR.

ingorichter · 2014-03-06T19:37:38Z

@resir014 @pace-noge Are you still working on this PR?

pace-noge · 2014-03-06T19:54:50Z

no, it's done that is our last commit.. sorry for late response, thank you

resir014 · 2014-03-06T23:55:22Z

@ingorichter @pace-noge Oh, nevermind. I was in a hurry and didn't notice I could make another PR.

And with that, yes, we're done. That was our final commit.

ingorichter · 2014-03-10T22:10:06Z

@resir014 @pace-noge In order to get this into the build, the conflict has to be resolved. Please remove all the LOCALE_* key/value pairs and update src/nls/root/strings-app.js to include a LOCALE_ID=... key/value pair with Indonesian as translated(native) value.

TomMalbran · 2014-03-10T22:19:57Z

src/nls/strings.js

@@ -59,6 +59,7 @@ define(function (require, exports, module) {
        "sr": true,
        "sv": true,
        "tr": true,
-        "zh-cn": true
+        "zh-cn": true,
+        "id": true


Can place this after "hu": true, so that the list is sorted?

…js to /src/nls/id/ remove all LOCALE_* on /src/nls/id/strings.js

ingorichter · 2014-03-11T18:38:18Z

@pace-noge @resir014 @TomMalbran I had to merge the PR manually due to merge conflicts and one missing urls.js file. Everything landed on master with b64a2a1
Thanks for your continued effort to get this PR landed. Very much appreciated!

pace-noge · 2014-03-11T23:19:20Z

thank you @ingorichter @resir014 @TomMalbran ..

njx assigned ingorichter Feb 10, 2014

marcelgerber reviewed Feb 12, 2014
View reviewed changes

ingorichter reviewed Mar 4, 2014
View reviewed changes

pace-noge added 2 commits March 5, 2014 14:28

Update strings.js

8de410b

Update strings.js

34e10ec

pace-noge added 3 commits March 6, 2014 02:29

fix conflict

c4ed695

Update strings.js after fix typo

bcca16c

fixed typo and using link from @resir014 for reference

Merge branch 'id' of https://github.com/pace-noge/brackets into id

dcf75aa

fix conflicted

e550114

resir014 mentioned this pull request Mar 7, 2014

Added Indonesian translation to samples page. #7116

Merged

TomMalbran reviewed Mar 10, 2014
View reviewed changes

pace-noge added 4 commits March 11, 2014 07:55

Sorted translation list

c85357e

remove all LOCALE_* key value pair

e8dc07c

Update String-app.js adding LOCALE_ID

040cee9

add LOCALE_ID: Indonesia to /src/nls/root/string-app.js, adding urls.…

d2f58a3

…js to /src/nls/id/ remove all LOCALE_* on /src/nls/id/strings.js

ingorichter merged commit d2f58a3 into adobe:master Mar 11, 2014

core-ai-bot mentioned this pull request Aug 30, 2021

[CLOSED] locale_id brackets-archive/bracketsIssues#6179

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

locale_id #6812

locale_id #6812

pace-noge commented Feb 9, 2014

marcelgerber Feb 12, 2014

ingorichter Feb 12, 2014

pace-noge Feb 13, 2014

resir014 commented Mar 4, 2014

ingorichter commented Mar 4, 2014

ingorichter Mar 4, 2014

pace-noge commented Mar 4, 2014

ingorichter commented Mar 4, 2014

resir014 commented Mar 5, 2014

ingorichter commented Mar 5, 2014

resir014 commented Mar 5, 2014

ingorichter commented Mar 5, 2014

pace-noge commented Mar 5, 2014

resir014 commented Mar 5, 2014

resir014 commented Mar 6, 2014

ingorichter commented Mar 6, 2014

ingorichter commented Mar 6, 2014

pace-noge commented Mar 6, 2014

resir014 commented Mar 6, 2014

ingorichter commented Mar 10, 2014

TomMalbran Mar 10, 2014

ingorichter commented Mar 11, 2014

pace-noge commented Mar 11, 2014

locale_id #6812

locale_id #6812

Conversation

pace-noge commented Feb 9, 2014

marcelgerber Feb 12, 2014

Choose a reason for hiding this comment

ingorichter Feb 12, 2014

Choose a reason for hiding this comment

pace-noge Feb 13, 2014

Choose a reason for hiding this comment

resir014 commented Mar 4, 2014

ingorichter commented Mar 4, 2014

ingorichter Mar 4, 2014

Choose a reason for hiding this comment

pace-noge commented Mar 4, 2014

ingorichter commented Mar 4, 2014

resir014 commented Mar 5, 2014

ingorichter commented Mar 5, 2014

resir014 commented Mar 5, 2014

ingorichter commented Mar 5, 2014

pace-noge commented Mar 5, 2014

resir014 commented Mar 5, 2014

resir014 commented Mar 6, 2014

ingorichter commented Mar 6, 2014

ingorichter commented Mar 6, 2014

pace-noge commented Mar 6, 2014

resir014 commented Mar 6, 2014

ingorichter commented Mar 10, 2014

TomMalbran Mar 10, 2014

Choose a reason for hiding this comment

ingorichter commented Mar 11, 2014

pace-noge commented Mar 11, 2014