Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Get project settings file loading earlier #6925

Closed
wants to merge 1 commit into from

Conversation

dangoor
Copy link
Contributor

@dangoor dangoor commented Feb 19, 2014

This will likely fix #6917. It's not a deterministic fix (that's #6910) but it will likely fix the test.

@dangoor
Copy link
Contributor Author

dangoor commented Feb 19, 2014

@RaymondLim or @redmunds want to review?

@redmunds
Copy link
Contributor

@dangoor This does not fix the test for me on Mac 10.8. Do you want to try to fix #6917 and #6910 in same pull request?

@dangoor
Copy link
Contributor Author

dangoor commented Feb 20, 2014

@redmunds Thanks for testing. I guess we'll need to turn the test off until #6910 can be fixed. I'd like to review #6719 before making any change related to #6910.

@redmunds
Copy link
Contributor

@dangoor I was wondering if we could just fix the test to wait for some other more reliable state?

@dangoor
Copy link
Contributor Author

dangoor commented Feb 20, 2014

@redmunds I could change it to wait until the preference changes, rather than immediately checking after the scope's path is set... I guess that's still testing what it's trying to test: that opening a project causes the project prefs to load. I can try that in the morning.

@dangoor
Copy link
Contributor Author

dangoor commented Feb 20, 2014

Closing this pull request. I've taken @redmunds advice and just modified the test a little bit to bit resilient to timing differences.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

One preference manager integration test is failing on Mac
2 participants