Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Update strings.js #7565

Merged
merged 1 commit into from May 29, 2014
Merged

Update strings.js #7565

merged 1 commit into from May 29, 2014

Conversation

ghost
Copy link

@ghost ghost commented Apr 18, 2014

No description provided.

@RaymondLim
Copy link
Contributor

@kvarel Thanks for making changes that I suggested in #7532. This is a new pull request because you're making changes in a new branch kvarel:patch-16 instead of kvarel:patch-15 branch. Can you switch back to kvarel:patch-15 and make a new commit in that branch? Then your changes will go into that pull request and we can close this one.

Before you make a new commit, you also need to make some other changes too. When you made changes that I mentioned in my comment, you need to adjust line numbers since all line numbers that I mentioned are based on the previous version of the file. If you insert a line, then all line numbers larger than that line need to add one.

"SAVE" : "Uložit",
"SAVE_AS" : "Uložit jako\u2026",
"SAVE_AND_OVERWRITE" : "Přepsat",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The block you're moving is two lines above the lines that I was referring to. So can you put back EXPERIMENTAL_BUILD and DEVELOPMENT_BUILD to where they were before, and then move the next two lines that should be here?

After that you move BUTTON_YES and BUTTON_NO to the end of this block. Once you're done, this block should look like below...

    // Obecné označení - dialogy, tlačítka
    "OK"                                   : "OK",
    "DONT_SAVE"                            : "Neukládat",
    "SAVE"                                 : "Uložit",
    "SAVE_AS"                              : "Uložit jako\u2026",
    "SAVE_AND_OVERWRITE"                   : "Přepsat",
    "CANCEL"                               : "Zrušit",
    "DELETE"                               : "Smazat",
    "BUTTON_YES"                           : "Ano",
    "BUTTON_NO"                            : "Ne",

@RaymondLim
Copy link
Contributor

@kvarel
Do you need help with committing to the other pull request?

@njx
Copy link
Contributor

njx commented May 14, 2014

@RaymondLim I think in general @kvarel is just editing through the web interface, so we probably need to go ahead and do the fixups ourselves (that's what we've done in the past).

@njx
Copy link
Contributor

njx commented May 14, 2014

Marking medium prioritiy since this is is a significant update.

@redmunds
Copy link
Contributor

@njx @RaymondLim When working with the Croatian contribution, I learned how to do it through directly editing on github.com so I could instruct contributor what to do. I updated nls/README.md in pull request #7840 with the info, in case it helps here.

@RaymondLim
Copy link
Contributor

Merging now so that I can fix it up the necessary changes.

RaymondLim added a commit that referenced this pull request May 29, 2014
@RaymondLim RaymondLim merged commit 11e58ea into adobe:master May 29, 2014
This was referenced May 29, 2014
@ghost ghost deleted the patch-16 branch October 9, 2014 08:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants