-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Fix StepsEditor labeling position bug on fontsizechange #7742
Conversation
Should the labels actually change their size? It looks to me that only the code size is changed and everything else stays the same, so maybe we should just change the labels font-size to use px so that those don't change in size. |
The |
Yes, that is the real issue here. If it was set in px, we wouldn't have any issue when changing the font size. |
@SAplayer The problem is that it's 75% of Editor font size, but it should be proportional to the rest of the UI so it doesn't zoom with editor. Take a look at the text in the header of the CSSInlineEditor (file name and New Rule button) and notice how it doesn't zoom when editor is zoomed. The font size there is simply set in px as @TomMalbran suggests. |
@redmunds So should we change it? |
Yes, it should be changed from
|
Changed. |
Looks good. Merging. |
Fix StepsEditor labeling position bug on fontsizechange
left: 0; | ||
width: 100%; | ||
padding: .3em .5em; | ||
padding: .3em .5em 0 .3em |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You missed the semicolons here, so I fixed it in 6dc1b4a
This fixes #6808 @redmunds @larz0