This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Update CSSCodeHints for latest CSS Shapes #7761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated shape-outside to have the correct list of values. Added shape-image-threshold and shape-margin.
|
Reviewing... |
|
@bemjb This looks good, but you need to sign the Brackets CLA first. Post a comment here top let me know when you sign it -- we're trying to close out Sprint 39 today! |
|
Looks good. Merging. |
redmunds
added a commit
that referenced
this pull request
May 6, 2014
Update CSSCodeHints for latest CSS Shapes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated shape-outside to have the correct list of values.
Added shape-image-threshold and shape-margin.
Note that although shape-inside is in Level 2 of the shapes specification and has been removed from the latest builds of Blink and WebKit, I haven't removed it from the completions. I'm happy to do that if others think we should do that.