Fixed #7673

[FezVrasta]

This is for #7673

[redmunds]

@FezVrasta I looked at your change and it seems safe, but I pasted the example from #7673 into a Brackets extension dialog and it doesn't seem to fix the problem. Let me know how I can test this out. Thanks.

[redmunds]

Also, I just upgraded Brackets to LESS 1.7.0. That doesn't seem to affect this change, but be sure that you test any new changes against the latest code in master.

[FezVrasta]

it compiles in

.table-striped > tbody tr:nth-child(odd) > td,
.table-striped > tbody tr:nth-child(odd) > th  {
    background-color: @tableBackgroundAccent;
}

So it should fix the problem.... if it doesn't I've not idea of why not :(

[redmunds]

@FezVrasta Re-opening -- didn't mean to Close. (for some reason I think that button means "close form").

[redmunds]

Actually, it's even more restrictive than that:

    .table-striped > tbody > tr:nth-child(odd) > td,
    .table-striped > tbody > tr:nth-child(odd) > th  {
        background-color: @tableBackgroundAccent;
    }

I suppose ti could be a bug in Chrome.

Can you show me the case that it fixes for you?

[FezVrasta]

Sorry what should I show you? I think I didn't get what you mean ^^"

[redmunds]

Explain to me what this fixes for you. It doesn't seem to have any effect in the example in #7673 (for me on Win7). I'm assuming that you are writing an extension that uses nested tables, is that correct? If so, can you provide a link to your extension so I can verify what this change does?

[FezVrasta]

The extension is Brackets Git, I use a nested table in the diff viewer. Thanks and sorry for the delay in my reply (weekend!)

[redmunds]

The extension is Brackets Git

Can I see it in the latest version, or is this in an un-merged branch? If so, what's the branch? Also, please provide a recipe -- I am not familiar with that extension.

[FezVrasta]

Yes you can see it in the production version, just try to commit something and a modal window with a code-viewer of the diff will be shown. It is made out with a table.

[redmunds]

I'm not seeing any difference in that dialog between your change and the master branch.

I looked at in in the Dev Tools Element inspector:

The main control is a div.table-striped element with a nested table. (FYI, that element has only 1 child, so it doesn't need to be striped).

Your change in this pull request is for .table-striped > tbody, so it doesn't apply to that case.

[FezVrasta]

div.table-striped > div.commit-diff > table > tbody

I want tbody to not be striped, so my edit should do exactly this, or am I missing something?

[redmunds]

My point is that the table-striped class only applies to the table tag, so it should be removed from that div tag. Anyway, this change makes sense, so merging.

[FezVrasta]

.table-striped "was" applied to any child table of the element with that class assigned.. not only to "table" elements with class "table-striped". (I think)