This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix UpdateNotification.Locale Fallback tests #7819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -218,13 +218,16 @@ define(function (require, exports, module) { | |||
|
|
|||
| function setupAjaxSpy(defaultUpdateUrl) { | |||
| var jq = spyOn(testWindow.$, "ajax").andCallFake(function (req) { | |||
| var d = $.Deferred(); | |||
| var d = new $.Deferred(); | |||
There was a problem hiding this comment.
little nit: new is optional.
There was a problem hiding this comment.
Well, it doesn't matter, right? I just did a quick search through the code and saw that mostly we use new $.Deferred();
There was a problem hiding this comment.
Our style guide explicitly says we should always use new
There was a problem hiding this comment.
Yeah, and roughly 50% of our code doesn't use it either. I agree that we should keep it consistent.
ingorichter
added a commit
that referenced
this pull request
May 15, 2014
Fix UpdateNotification.Locale Fallback tests
|
@ingorichter Is this ready to merge or did you not do a full formal code review on it yet? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in #7811, the tests for that particular feature are succeeding right now while they shouldn't.
This fixes it - they'll fail right now on master, but as soon as release is merged back into master (including b325668), they'll work again.
@ingorichter