This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
some tests to clarify what convertToNativePath does. Issue #3872 #7957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chirayu11 Thank you very much for the contribution. Currently the build fails because of code formatting issues. Please have a look at the Travis CI link above. Travis is running JSHint on the source code. You can do the same from inside the brackets directory by running |
|
Created new PR to fix the formatting issues. Thanks for the contribution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added some tests as a start to clarify what convertToNativePath is doing. I can rename the method (should I copy it and deprecate the old one?).
#3872