This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Saving Theme changes when pressing enter #8382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -96,7 +96,7 @@ define(function (require, exports, module) { | |||
| var attr = $target.attr("data-target"); | |||
| newSettings[attr] = $target.is(":checked"); | |||
| }) | |||
| .on("change", "[data-target]:text", function () { | |||
| .on("keyup", "[data-target]:text", function () { | |||
There was a problem hiding this comment.
.on("input" should be the preferred HTML5ey way to do it. That will fire regardless of whether the change occurred via keystroke, Paste menu item, IME, etc.
There was a problem hiding this comment.
@peterflynn Good point. Let change and test...
dangoor
added a commit
that referenced
this pull request
Jul 15, 2014
Saving Theme changes when pressing enter
|
Looks good. Much more pleasant this way! |
|
@dangoor I agree :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8378