Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Themes scrollbars #8505

Merged
merged 3 commits into from
Jul 22, 2014
Merged

Themes scrollbars #8505

merged 3 commits into from
Jul 22, 2014

Conversation

MiguelCastillo
Copy link
Contributor

This is basically a redo of #8493, because I messed the history after rebasing instead of merging.

@MiguelCastillo
Copy link
Contributor Author

cc @dangoor

@TomMalbran
Copy link
Contributor

@MiguelCastillo @dangoor To fix the custom scrollbars issue I am thinking that we need to scope the default scrollbars to everything except for the editor using a :not() selector. By doing that we get by default the system scrollbars in the editor. And finally, we can add the custom scrollbars to the Light Theme less file.

@dangoor
Copy link
Contributor

dangoor commented Jul 22, 2014

@TomMalbran Some of us were just discussing this. Rather than having the toggle being for "Use system scrollbars", we'll change the toggle to say "Use theme scrollbars". So, the switch is going to be between Brackets' default (customized) scrollbars which will come in both light and dark and the scrollbars that are provided by the theme.

@TomMalbran
Copy link
Contributor

@dangoor That is a good option

@MiguelCastillo
Copy link
Contributor Author

So, we want to go with "Use theme scrollbars"? That's the text I used in my first encarnation of the setting. It eventually mutated to what it is now. :)

I like it too.

cc @ryanstewart

@dangoor
Copy link
Contributor

dangoor commented Jul 22, 2014

Change looks good. Merging

dangoor added a commit that referenced this pull request Jul 22, 2014
@dangoor dangoor merged commit 34c37ee into adobe:master Jul 22, 2014
@MiguelCastillo MiguelCastillo deleted the themes-scrollbars branch July 22, 2014 21:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants