Move non-theme-specific inline editor styles into core. #8580
Conversation
| @@ -241,6 +241,10 @@ | |||
|
|
|||
| } | |||
|
|
|||
| .inline-widget .CodeMirror, .inline-widget .CodeMirror-gutters { | |||
| background: transparent; | |||
There was a problem hiding this comment.
This needs to be background: transparent !important; because the other rule with "#editor-holder" has a higher specificity and can override this.
There was a problem hiding this comment.
I could add #editor-holder to this. Is that cleaner than adding !important?
There was a problem hiding this comment.
Hmm... I don't actually see a problem from this.
|
I've pushed changes based on @larz0's comments |
|
@dangoor looks good. Merging. |
Move non-theme-specific inline editor styles into core.
| @@ -241,6 +241,10 @@ | |||
|
|
|||
| } | |||
|
|
|||
| #editor-holder .inline-widget .CodeMirror, #editor-holder .inline-widget .CodeMirror-gutters { | |||
| background: transparent; | |||
There was a problem hiding this comment.
Looks fine here: http://cl.ly/image/173n0z2E2C27
There was a problem hiding this comment.
@larz0 You mean looks fine with that selector removed? If it looks fine with it removed, want to submit a tiny cleanup PR to make that change? (I guess targeted at master -- no point in squeezing it onto the release branch).
Fix for #8571 (targeting release branch).
@larz0 can you take a look?
@mackenza does this do the trick for you?