Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

update recent language changes #8678

Closed
wants to merge 2 commits into from
Closed

update recent language changes #8678

wants to merge 2 commits into from

Conversation

airycanon
Copy link
Contributor

update recent language changes

airycanon added 2 commits August 7, 2014 01:56
@airycanon
Copy link
Contributor Author

It says that I have NOT submitted the contributor license agreement. Is this the exact reason why
Travis CI build failed?
Please help me,thanks.

@ghost
Copy link

ghost commented Aug 7, 2014

Yes. You have sign the agreement.

On Thu, Aug 7, 2014 at 9:32 AM, airycanon notifications@github.com wrote:

It says that I have NOT submitted the contributor license agreement. Is
this the exact reason why
Travis CI build failed?
Please help me,thanks.

—
Reply to this email directly or view it on GitHub
#8678 (comment).

@airycanon
Copy link
Contributor Author

Hi,ramsundhar20.
I will submitt the license agreement later. Thank for your replies. :)

redmunds
redmunds reviewed Aug 12, 2014
View reviewed changes
src/nls/zh-cn/strings.js
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2013 Adobe Systems Incorporated. All rights reserved.
* Copyright (c) 2014 Adobe Systems Incorporated. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copyright should be the date the file was created (2013).

@redmunds
Copy link
Contributor

The branch says "Unknown Repository". Did you delete the local branch?

@ingorichter
Copy link
Contributor

@airycanon Thank you for updating the translation. Are you still interested in finishing this PR? Please let us know, so that we can move on with this PR. Thanks.

@airycanon
Copy link
Contributor Author

@redmunds @ingorichter Sorry for the late reply, I have committed the translations in another request.
My English is not good enough,If any questions,please let me know,thanks for your help.

@redmunds
Copy link
Contributor

What's the difference between this one and #8687? #8687 has the copyright fixed and a good branch, so maybe close this one?

@redmunds
Copy link
Contributor

The strings changed in this PR are the same as #8687. Closing this one.

@redmunds redmunds closed this Aug 26, 2014
@core-ai-bot core-ai-bot mentioned this pull request Aug 30, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
PR Triage Complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@airycanon @redmunds @ingorichter