This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix outdated comments in StringUtils truncate()
#8707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param {number} len Length to which text should be limited. | ||
| * @return {string} Returns truncated text only if it was changed. | ||
| * @param {number} len Length to which text should be truncated | ||
| * @return {string} Returns truncated text only if it was changed |
There was a problem hiding this comment.
Nit: can you change this to {?string} to indicate that it can return undefined?
|
@le717 Just that one suggestion, looks fine to merge other than that |
|
@peterflynn Done. |
|
Looks good -- thanks! |
peterflynn
added a commit
that referenced
this pull request
Aug 11, 2014
Clean up comments in StringUtils `truncate()`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I must have stared at this code so much I did not realize they were outdated until right now. 😄