Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Append buildnumber to version to make UpdateNotification check work again #9715

Merged
merged 1 commit into from
Oct 28, 2014

Conversation

ingorichter
Copy link
Contributor

The missing build number broke the UpdateNotification check. This fixes it.

@ingorichter
Copy link
Contributor Author

Hi @dangoor, perhaps we should add + instead - to make the buildnumber semver compliant. This would require a small change for the UpdateNotification check, since the - is used to split up the buildnumber.

@dangoor
Copy link
Contributor

dangoor commented Oct 28, 2014

Ha! I did exactly the same change in #9721, but I also updated the version number in that PR. Can we just go with that one?

@ingorichter
Copy link
Contributor Author

Sure. What about the change with the + instead of -?

ingorichter added a commit that referenced this pull request Oct 28, 2014
Append buildnumber to version to make UpdateNotification check work again
@ingorichter ingorichter merged commit 32536dc into master Oct 28, 2014
@ingorichter ingorichter deleted the ingo/add-buildnumber-to-version branch October 28, 2014 18:55
@dangoor
Copy link
Contributor

dangoor commented Oct 28, 2014

Seemed better to me to just stick with -.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants