Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments misplaced after initial run due to module directives being moved #29

Closed
novaugust opened this issue May 4, 2023 · 0 comments · Fixed by #53
Closed

Comments misplaced after initial run due to module directives being moved #29

novaugust opened this issue May 4, 2023 · 0 comments · Fixed by #53
Labels
bug Something isn't working

Comments

@novaugust
Copy link
Contributor

novaugust commented May 4, 2023

Making an issue to pre-empt others experiences ^.^ Feel free to +1 if you were affected by this, or leave an example snippet of the "before" code


Most of our styles don't take comments into account, and can get away with it. defs is the exception.

ModuleDirectives currently moves comments around on an initial run as it does its big rewrites.

ideally this wouldn't be the case, but for now it's less work to manually put things back where they should be than it is to write the code to do it automatically :)

@novaugust novaugust added the bug Something isn't working label May 4, 2023
novaugust added a commit that referenced this issue Jun 22, 2023
Co-authored-by: Greg Mefford <gmefford@adobe.com>
novaugust added a commit that referenced this issue Jun 22, 2023
* Fix ModuleDirectives comments (Closes #29)

Co-authored-by: Greg Mefford <gmefford@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant