Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pipes Bugs #16

Merged
merged 4 commits into from
Apr 16, 2023
Merged

Fix Pipes Bugs #16

merged 4 commits into from
Apr 16, 2023

Conversation

novaugust
Copy link
Contributor

@novaugust novaugust commented Apr 16, 2023

Closes #15

  • a |> b created invalid ast due to b having ast {:b, _meta, nil = _args}, causing us to create the improper list [a | nil]
  • == was mistakenly not included in the list of math/comparison operators that are valid starts to a pipe

also snuck in another QOL improvement for helping show invalid AST when running tests

test/style/pipes_test.exs Outdated Show resolved Hide resolved
@novaugust novaugust merged commit 3c7816f into main Apr 16, 2023
@novaugust novaugust deleted the me/single-pipe-bugs branch April 16, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Invalid code produced when piping operator statement with parentheses into function
1 participant