Remove unless from codebases #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novaugust
force-pushed
the
me/no-more-unless
branch
from
208227b to
3f18d04
Compare
novaugust
force-pushed
the
me/no-more-unless
branch
from
078546c to
7b9e7eb
Compare
emkguts
added a commit
to smartrent/elixir-styler
that referenced
this pull request
Sep 24, 2024
* fix infinite loop rewriting negated if with empty do body. closes adobe#196 * Remove unless from codebases (adobe#194) * use `not` over `!` when rewriting `unless a (> >= < <= in) b` * actually, lets only do `not` for `in` * v1.1.0 * update version in readme * Don't pipe into `Kernel.!` when rewriting unless with pipes --------- Co-authored-by: Matt Enlow <enlow@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unless is being deprecated
unless is complex to read